Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: e00552eaaa41
Choose a base ref
...
head repository: jruby/jruby
compare: a93ed52ff508
Choose a head ref
  • 13 commits
  • 7 files changed
  • 1 contributor

Commits on Nov 17, 2016

  1. avoid and deprecate sub19 versions on Ruby String

    @kares
    kares committed Nov 17, 2016
    Copy the full SHA
    863f420 View commit details
    Browse the repository at this point in the history

  2. dry out String#sub impl - pass less to privates let them handle arg0

    @kares
    kares committed Nov 17, 2016
    Copy the full SHA
    ed97a60 View commit details
    Browse the repository at this point in the history

  3. no need to do the frozenCheck twice on #sub!

    @kares
    kares committed Nov 17, 2016
    Copy the full SHA
    a425196 View commit details
    Browse the repository at this point in the history

  4. no ByteList sharing actually since we're creating a new one here

    @kares
    kares committed Nov 17, 2016
    Copy the full SHA
    cddeb58 View commit details
    Browse the repository at this point in the history

  5. sub-ing with replacement does not need a matcher + house-keeping

    @kares
    kares committed Nov 17, 2016
    Copy the full SHA
    1d215bf View commit details
    Browse the repository at this point in the history

  6. re-use helper method to convert/retrieve regexp argument

    @kares
    kares committed Nov 17, 2016
    Copy the full SHA
    5a254fc View commit details
    Browse the repository at this point in the history

  7. compare ints instead of making fixnums + avoid getCurrentContext

    @kares
    kares committed Nov 17, 2016
    Copy the full SHA
    8815c19 View commit details
    Browse the repository at this point in the history

  8. move single-byte-optimizable check into strLengthFromRubyString 

    has been a source of slow-ness for usage such as the `str.index('...')` : 

before:
```
(('foo' * 100) + '012').index('01') [10000000x]      5.120000   0.040000   5.160000 (  5.146903)
```
after:
```
(('foo' * 100) + '012').index('01') [10000000x]     2.280000   0.100000   2.380000 (  2.374061)
```
2.3.1:
```
(('foo' * 100) + '012').index('01') [10000000x]     1.950000   0.000000   1.950000 (  1.955884)
```
    @kares
    kares committed Nov 17, 2016
    Copy the full SHA
    7e7cb5e View commit details
    Browse the repository at this point in the history

  9. correct a typo + made a private helper method static

    @kares
    kares committed Nov 17, 2016
    Copy the full SHA
    5deedbd View commit details
    Browse the repository at this point in the history

  10. only check encoding once + deprecate choppedLength19 method

    @kares
    kares committed Nov 17, 2016
    Copy the full SHA
    8febff9 View commit details
    Browse the repository at this point in the history

  11. [travis-ci] decrease meta/perm size + echo _OPTS before script is run

    @kares
    kares committed Nov 17, 2016
    Copy the full SHA
    dd8e670 View commit details
    Browse the repository at this point in the history

  12. one adjustStartPos is enough; check() before field (avoids NPE) 

    also consintently use runtime local variable instead of getRuntime()
    @kares
    kares committed Nov 17, 2016
    Copy the full SHA
    2fcd310 View commit details
    Browse the repository at this point in the history

  13. refactor concurrentModification internal to return and throw

    @kares
    kares committed Nov 17, 2016
    Copy the full SHA
    a93ed52 View commit details
    Browse the repository at this point in the history