lxqt: better organize system packages #20492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
tindzk
reviewed
Nov 17, 2016
| let | ||
| pkgName = drv: (builtins.parseDrvName drv.name).name; | ||
| ysNames = map pkgName ys; | ||
| res = (filter (x: !(builtins.elem (pkgName x) ysNames)) xs); |
There was a problem hiding this comment.
I believe this line can be deleted.
| default = []; | ||
| example = literalExample "[ pkgs.lxqt.qterminal ]"; | ||
| type = types.listOf types.package; | ||
| description = "Which packages LXQt should exclude from the default environment"; |
There was a problem hiding this comment.
Which packages LXQt should exclude -> Which LXQt packages to exclude
Split packages in three categories, all of them going into the system package list: - pre-requisite packages - core packages - optional packages Add a new configuration option 'environment.lxqt.excludePackages' to specify optional LXQt packages that should be excluded from system packages. Add 'gvfs' as a pre-requisite package, needed by 'pcmanfm-qt' to handle virtual places, like "Computer" and "Network".
|
Tested successfully and pushed to master (2e71054). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Better organization of system packages used by LXQt inspired by the GNOME module.
Split packages in three categories, all of them going into the system package list:
Add a new configuration option 'environment.lxqt.excludePackages' to specify optional LXQt packages that should be excluded from system packages.
Add 'gvfs' as a pre-requisite package, needed by 'pcmanfm-qt' to handle virtual places, like "Computer" and "Network".
Obsoletes #20426.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)