tahoe service: use ExecStart instead of script #20554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since only a single command is necessary to start Tahoe it is sufficient to use ExecStart and thereby skip starting up Bash (and leaving it running).
|
@rycee, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MostAwesomeDude and @ericsagnes to be potential reviewers. |
|
You've run this, and can verify it works as a service? |
|
Yeah, I'm successfully running this at the moment, albeit back ported to 16.09. |
fpletz
approved these changes
Nov 20, 2016
|
Since there weren't any major objections I've merged this in commit 8a424e3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
To avoid having an unnecessary Bash instance running for each Tahoe node. An alternative way to solve this would be to change the
scriptvariable to readexec tahoe start …but since it is only a single command I figuredExecStartis more straightforward.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)