Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.pipes-binary: dontCheck #20545

Closed
wants to merge 1 commit into from
Closed

haskellPackages.pipes-binary: dontCheck #20545

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 19, 2016

Motivation for this change
Things done
  • [ X] Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • [X ] NixOS
    • macOS
    • Linux
  • [ X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • [ X] Fits CONTRIBUTING.md.

Tests depend on binary <0.8

Tests depend on binary <0.8
@mention-bot
Copy link

@Chattered, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @acowley and @bennofs to be potential reviewers.

@peti
Copy link
Member

peti commented Nov 19, 2016

Please report this issue upstream and, if possible, add the URL of the appropriate ticket in a comment next to the override.

@joachifm
Copy link
Contributor

joachifm commented Mar 8, 2017

Though I had to jail break it, haskellPackages.pipes-binary built fine for me on current Nixpkgs so doesn't look to me like there's a problem with the test suite --- at least not for our current default haskell package set.

@joachifm joachifm closed this Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants