Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 48cc9ba915b3
Choose a base ref
...
head repository: jruby/jruby
compare: 4e775c76e31d
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Oct 13, 2016

  1. Don't dup every element in Enumerator#drop 

    In 06f0441 (JRUBY-6892) Enumerable#drop was changed to call #dup on every element that ended up in the result, but that might not work. Not all objects correctly implement #dup, or are even allocatable.

#take was not changed, and looking at the differences between #take and #drop the only thing that stood out was that the signature of the #each call was different. Changing from Signature.NO_ARGUMENTS to Signature.ONE_REQUIRED make the issue that 06f0441 tried to fix go away.
    @iconara
    iconara committed Oct 13, 2016
    Copy the full SHA
    6996e2e View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2016

  1. Merge pull request #4225 from iconara/fix-4218-9k 

    Don't dup every element in Enumerator#drop (9K)
    @headius
    headius committed Nov 8, 2016
    Copy the full SHA
    4e775c7 View commit details
    Browse the repository at this point in the history