Skip to content

Commit

Permalink
[Truffle] Replace most calls to createRope by encodeRope.
Browse files Browse the repository at this point in the history
  • Loading branch information
eregon committed Nov 8, 2016
1 parent fd5b2f1 commit b11a300
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 9 deletions.
Expand Up @@ -244,7 +244,7 @@ public static Rope shimModifiers(Rope bytes) {
throw new UnsupportedOperationException();
}

bytes = StringOperations.createRope(bytesString, ASCIIEncoding.INSTANCE);
bytes = StringOperations.encodeRope(bytesString, ASCIIEncoding.INSTANCE);
}

return bytes;
Expand Down
Expand Up @@ -1295,7 +1295,7 @@ public DynamicObject initialize(DynamicObject self, NotProvided from) {
@Specialization
public DynamicObject initializeJavaString(DynamicObject self, String from) {
raiseIfFrozen(self);
StringOperations.setRope(self, StringOperations.createRope(from, ASCIIEncoding.INSTANCE));
StringOperations.setRope(self, StringOperations.encodeRope(from, ASCIIEncoding.INSTANCE));
return self;
}

Expand Down
Expand Up @@ -146,7 +146,7 @@ public abstract static class ArrayStorageNode extends CoreMethodArrayArgumentsNo
@Specialization(guards = "isRubyArray(array)")
public DynamicObject arrayStorage(DynamicObject array) {
String storage = ArrayStrategy.of(array).toString();
return StringOperations.createString(getContext(), StringOperations.createRope(storage, USASCIIEncoding.INSTANCE));
return StringOperations.createString(getContext(), StringOperations.encodeRope(storage, USASCIIEncoding.INSTANCE));
}

}
Expand Down
Expand Up @@ -16,6 +16,7 @@
import org.jruby.truffle.builtins.CoreClass;
import org.jruby.truffle.builtins.CoreMethod;
import org.jruby.truffle.builtins.CoreMethodArrayArgumentsNode;
import org.jruby.truffle.core.rope.CodeRange;
import org.jruby.truffle.core.string.StringOperations;

@CoreClass("Truffle::Gem::BCrypt")
Expand All @@ -30,9 +31,8 @@ public Object hashpw(DynamicObject secret, DynamicObject salt) {
final String result = BCrypt.hashpw(
StringOperations.getString(secret),
StringOperations.getString(salt));
return StringOperations.createString(
getContext(),
StringOperations.createRope(result, USASCIIEncoding.INSTANCE));
return StringOperations.createString(getContext(),
StringOperations.encodeRope(result, USASCIIEncoding.INSTANCE, CodeRange.CR_7BIT));
}
}

Expand All @@ -42,9 +42,8 @@ public abstract static class GenerateSalt extends CoreMethodArrayArgumentsNode {
@TruffleBoundary
@Specialization
public Object gensalt(int cost) {
return StringOperations.createString(
getContext(),
StringOperations.createRope(BCrypt.gensalt(cost), USASCIIEncoding.INSTANCE));
return StringOperations.createString(getContext(),
StringOperations.encodeRope(BCrypt.gensalt(cost), USASCIIEncoding.INSTANCE, CodeRange.CR_7BIT));
}
}
}

0 comments on commit b11a300

Please sign in to comment.