You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
hey @kirs, thanks for the report. the test sound like it could be improved for the benefit of all :)
doubt there's actually any user reports on the behaviour and see no benefit in relying on the MRI specifics of how floats behave in that particular test ... would be perfect if it simply did compare ~ 97.19 > 97.18
-> should also make understanding the test code easier for any future numericality validation readers/writers
Rails relies on the fact that the 97.18 as a float is greater than 97.18 as a BigDecimal due to floating point precision (https://github.com/rails/rails/blob/master/activemodel/test/cases/validations/numericality_validation_test.rb#L85
).
In JRuby that's not the case and a few ActiveModel tests fail:
is it something that we can change in JRuby? or should we skip those tests in Rails when running on JRuby?
@headius
The text was updated successfully, but these errors were encountered: