Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 6ea39ea4d718
Choose a base ref
...
head repository: jruby/jruby
compare: 46aca6c47934
Choose a head ref
  • 5 commits
  • 2 files changed
  • 2 contributors

Commits on Nov 16, 2016

  1. add Kahan's compensated algorithm for Floats 

    Fixes part of a bug identified in #4297
    @phluid61
    phluid61 committed Nov 16, 2016
    Copy the full SHA
    be05f1b View commit details
    Browse the repository at this point in the history

  2. make Array#sum use Enumerable's addition logic 

    Partially addresses a bug in #4297
    @phluid61
    phluid61 committed Nov 16, 2016
    Copy the full SHA
    343028a View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2016

  1. change Array#sum to better match MRI 

    Fixes most of the tests that weren't perfect in #4297.
    @phluid61
    phluid61 committed Nov 17, 2016
    Copy the full SHA
    8a78908 View commit details
    Browse the repository at this point in the history

  2. fix Array#sum to handle Fixnum overflow 

    This passes the final MRI test, referenced in #4297
    @phluid61
    phluid61 committed Nov 17, 2016
    Copy the full SHA
    e49d272 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #4309 from phluid61/feature/optimise-enumerable-sum 

    fix Array#sum and Enumerable#sum
    @headius
    headius committed Nov 17, 2016
    Copy the full SHA
    46aca6c View commit details
    Browse the repository at this point in the history