fix Array#sum and Enumerable#sum #4309
Merged
+231
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
Array#sum
andEnumerable#sum
to use Kahan's compensated summation algorithm, so we have the same rounding artifacts as MRI.It also includes some of the MRI's cascading coercion behaviour in
Array#sum
Now all tests in
test/mri/ruby/test_array.rb
andtest/mri/ruby/test_enum.rb
pass, except for those depending on 'mathn' which I can't test because of an unrelated issue.Consider this a regression fix for #4297