Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: fa933ff2a04b
Choose a base ref
...
head repository: jruby/jruby
compare: 7ec25d90a04b
Choose a head ref
  • 3 commits
  • 5 files changed
  • 1 contributor

Commits on Nov 17, 2016

  1. [Truffle] Changed inequality to be consistent with the rest of the co… 

    …de base.
    @nirvdrum
    nirvdrum committed Nov 17, 2016
    Copy the full SHA
    eedac46 View commit details
    Browse the repository at this point in the history

  2. [Truffle] Fixed a bad case in the string_chr_at primitive.

    @nirvdrum
    nirvdrum committed Nov 17, 2016
    Copy the full SHA
    61bbe6f View commit details
    Browse the repository at this point in the history

  3. [Truffle] Removed the character_ascii_p primitive. 

    The only two places this primitive was being used was in String#chop! and String#chomp!. In both cases, the character's codepoint was already being inspected, so checking if it also was in the valid US-ASCII codepoint range was redundant and a bit misleading. There is a bug here in that non-ASCII-compatible encodings may use values other than 0x0A and 0xAD for LF and CR, but the existing code didn't guard against that. Moreover, MRI doesn't guard against that either, so any fix there would come at the expense of breaking compatibility with MRI. As it stands, the only such encodings in MRI are dummy encodings, which aren't fully supported anyway.
    @nirvdrum
    nirvdrum committed Nov 17, 2016
    Copy the full SHA
    7ec25d9 View commit details
    Browse the repository at this point in the history