Automatically unpack Tuple when sorting arrays #3539
Merged
+9
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid capturing the block used for sorting, allowing automatic unpacking of Tuples.
Since the block is only required in the inner
#quicksort!
function, this change gives some flexibility to the user allowing them write more expressive code.In the following example:
Both
sort_by
calls produce the same result, one being more cryptic and the other being explicit about unpacking.In comparison:
Produces the same results more transparently to the developer writing the code and behaves similar to other methods that perform automatic unpack like
#map
or#each
.Performance-wise, this change does introduce a speedup on synthetic benchmarks:
Fixes #3419