Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: bed76e78e75a
Choose a base ref
...
head repository: jruby/jruby
compare: b1df1bac53ac
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Nov 18, 2016

  1. Implement Thread{.,#}report_on_exception[=]. 

    This impl works as follows:

* Default global value is nil.
* nil = report when thread is GC if nobody has captured the
  exception (i.e. called #join or #value or abort_on_exception
  logic has fired).
* true = report when the thread terminates, regardless of capture.
* false = never report.
* New threads inherit the current global setting.
* If a thread name has been set from Ruby, it will be combined
  with JRuby's internal name for the report. If it has not been
  set, we will just report the internal thread name.

There are some open questions for this feature:

* If join/value are interrupted, should they still set the capture
  bit? My impl does not; they must complete.
* Is the VERBOSE-like nil/true/false clear enough or should we use
  symbols like :off, :gc, :on?
    @headius
    headius committed Nov 18, 2016
    Copy the full SHA
    e408638 View commit details
    Browse the repository at this point in the history

  2. Remove report-on-GC to align with MRI 2.4. #4293 

    See https://bugs.ruby-lang.org/issues/6647
    @headius
    headius committed Nov 18, 2016
    Copy the full SHA
    b1df1ba View commit details
    Browse the repository at this point in the history