Commits on May 28, 2016

1. Implement CharSequence in RubyString. …

   There's an important breaking change here: the `length` method
   had only its return value changed, from RubyFixnum to int. We only
   called this method from within RubyString itself, but it was
   public and could be called by third-party Java code that would now
   break at runtime and fail to compile.
   
   Ruby code calling `length` will continue to work properly, since
   the new int return value will just coerce into a RubyFixnum.

   

   headius committed May 28, 2016
   Copy the full SHA

   11272b1 View commit details

   Browse the repository at this point in the history

2. Implement Thread{.,#}report_on_exception[=]. …

   This impl works as follows:
   
   * Default global value is nil.
   * nil = report when thread is GC if nobody has captured the
     exception (i.e. called #join or #value or abort_on_exception
     logic has fired).
   * true = report when the thread terminates, regardless of capture.
   * false = never report.
   * New threads inherit the current global setting.
   * If a thread name has been set from Ruby, it will be combined
     with JRuby's internal name for the report. If it has not been
     set, we will just report the internal thread name.
   
   There are some open questions for this feature:
   
   * If join/value are interrupted, should they still set the capture
     bit? My impl does not; they must complete.
   * Is the VERBOSE-like nil/true/false clear enough or should we use
     symbols like :off, :gc, :on?

   

   headius committed May 28, 2016
   Copy the full SHA

   d00c89f View commit details

   Browse the repository at this point in the history