network interfaces: Reduce the start rate limit interval from 10 to 3 seconds #20222
Conversation
|
@spacekitteh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @groxxda and @kampfschlaefer to be potential reviewers. |
|
Actually, "StartLimitIntervalSec = 3;" should also go into the "network-link-${i.name}" service in network-interfaces.nix, but the github web editor can't do that. |
|
@spacekitteh When you have the branch (which you have since thats needed for pull requests), you can make additional commits and edit more files. Be aware: when you only edit via web editor of github, your PR will most likely not fit this projects requirements: Multiple commits for one topic, no local execution of any tests and maybe some more… So while I like the web editor of github, please give your PR better chances of acceptance by checking out your branch locally and testing it. |
| @@ -84,6 +84,7 @@ in | |||
| serviceConfig = { | |||
| Type = "oneshot"; | |||
| RemainAfterExit = true; | |||
| StartLimitIntervalSec = 3; | |||
There was a problem hiding this comment.
This should probably be a configuration option.
|
@spacekitteh What exactly is your problem here? Networking devices that are not yet available or just waiting for DHCP? In the latter case, dhcpcd would be the right place to change this. I don't think static configurations suffer from wait time at boot. |
|
@fpletz I'm about 90% sure it's due to the device itself. |
|
@spacekitteh Any update on this pull request? |
|
Closing due to lack of activity, feel free to reopen this if needed. |
Motivation for this change
Sometimes, network connections fail a few times before they're stable. During boot, I don't want to have to wait 10 seconds in between attempting each phase of establishing a stable ethernet connection. So this lowers that.