-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Math.lgamma with input -0.0 #4299
Merged
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a cornercase in Math.lgamma if the input is a negative zero. This patch fixes it by adding that explicit corner case to the if statement.
you're right, MRI seems to do it this way :
|
This appears to have broken a spec. Are the specs out of date?
|
headius
added a commit
that referenced
this pull request
Nov 17, 2016
Move specs out of allowed failures when repaired. |
headius
added a commit
that referenced
this pull request
Nov 17, 2016
headius
added a commit
that referenced
this pull request
Nov 17, 2016
in that case this caused a regression ... |
@kares Thanks! I undid the travis exclude and just tagged it btw. |
kares
added a commit
to kares/jruby
that referenced
this pull request
Nov 17, 2016
... reverting spec tagging at e07c718
kares
added a commit
that referenced
this pull request
Nov 17, 2016
... reverting spec tagging at e07c718
kares
added a commit
that referenced
this pull request
Nov 17, 2016
... reverting spec tagging at e07c718
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a cornercase in Math.lgamma if the input is a negative zero.
This patch fixes it by adding that explicit corner case to the if
statement.