Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.docx2txt: init at 0.6 #20431

Closed
wants to merge 1 commit into from
Closed

Conversation

hbunke
Copy link
Contributor

@hbunke hbunke commented Nov 15, 2016

Motivation for this change

docx2txt is a pure python-based utility to extract text from docx files; handy for viewing Word docx files within Mutt.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@hbunke hbunke force-pushed the docx2txt branch 2 times, most recently from d119b71 to 0dc65b9 Compare November 16, 2016 10:42
sha256 = "0f0kzs5mnphjnv6g21xfsjaj8fs9mgs6s849qnpq7r65fijhqx14";
};

propagatedBuildInputs = with self; [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for this line here

@FRidh
Copy link
Member

FRidh commented Nov 17, 2016

Did you check whether the tests are run?

exclude darwin (for now)
@hbunke
Copy link
Contributor Author

hbunke commented Nov 21, 2016

Which tests do you mean?

@FRidh
Copy link
Member

FRidh commented Nov 30, 2016

Which tests do you mean?

Those that are apparently not included in the archive. If tests aren't included in Python source packages we set doCheck = false;.

@FRidh
Copy link
Member

FRidh commented Nov 30, 2016

Note that this needs to be rebased.

@FRidh
Copy link
Member

FRidh commented Jan 2, 2017

Please open a new PR if you still would like to get this in.

@FRidh FRidh closed this Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants