-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring Darwin frameworks and libs into scope in all packages by default #10653
Conversation
Create stub packages for Darwin to avoid evaluation failures. This reverts commit c416c3a.
+1 makes things much all-packages.nix much nicer to look at ... any objections to not merge this? |
(triage) would we like to get this rebased and merged? |
@pikajude ping. could you rebase this on current master? |
I think, he won't. maybe somebody else wants to do this? @peti do you use mac os x? |
👍 for the cleanup/idea, but we'll have beware of name clashes. Note that Darwin seems short on maintainers currently and it's likely this won't be among the top priorities (but that depends on the particular people). |
@Mic92, I don't have access to a Darwin machine, I'm afraid; I won't be able to help much with this PR. |
@peti sorry I thought you did. |
@copumpkin, @vbgl, @acowley, @grahamc, could you help to rebase this? |
To ground things like name collision concerns a bit, here is the list of identifiers that would be brought into scope. I would like to see some simplification to the mechanism by which darwin-specific dependencies are pulled in:
I think I'd be more inclined to have a simple (maybe default scope) way of bringing in a large subset of the system frameworks, |
I added |
@LnL7 would that become the I’d be happy if we moved @gilligan I certainly don’t want to be an obstructionist to this effort, so if you have an idea of how something like the |
@acowley No it's opt-in, currently most expressions explicitly pass the darwin dependencies they need. With {
libusb1 = callPackage ../development/libraries/libusb1 {
inherit (darwin) libobjc;
inherit (darwin.apple_sdk.frameworks) IOKit;
};
libusb1 = darwin.callPackage ../development/libraries/libusb1 {};
} |
@wizeman @orivej another example of an accidentally closed issue @pikajude I'm still on the fence about this one but could be swayed if you feel strongly about it. I definitely don't like having to pass all the frameworks around explicitly, but am also fearful of some very easy confusion with some of the Apple libraries, including things like |
Anyone wants to pick up this work or can we close it due to inactivity? |
Creates stub packages for Darwin to avoid evaluation failures.