Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundler ruby specification fails if not set to 2.2.2 #3427

Closed
jtarchie opened this issue Oct 26, 2015 · 5 comments
Closed

bundler ruby specification fails if not set to 2.2.2 #3427

jtarchie opened this issue Oct 26, 2015 · 5 comments

Comments

@jtarchie
Copy link

With the following JRuby,

$ jruby --version
jruby 9.0.3.0 (2.2.2) 2015-10-21 633c9aa Java HotSpot(TM) 64-Bit Server VM 25.25-b02 on 1.8.0_25-b17 +jit [darwin-x86_64]`

And the following Gemfile,

source 'https://rubygems.org'

ruby '2.2.3', :engine => 'jruby', :engine_version => '9.0.3.0'

And you run bundle install,
You see this error message,

Your Ruby version is 2.2.2, but your Gemfile specified 2.2.3

JRuby claims to be 2.2.x compatible. Should this be updated so it is explicit?

@donv
Copy link
Member

donv commented Oct 26, 2015

This is the same behaviour as with MRI.

You should file an issue with bundler if you (like me) want it changed:

rubygems/bundler#2213

JRuby will probably update the line you mentioned, but then your example with fail for all Gemfiles specifying ruby '2.2.2'.

@jtarchie
Copy link
Author

@donv, I think we are on the same page with bundler.

My point for this issue was that it wasn't clear in any docs that JRuby was locked at 2.2.2. The blog post specifically says 2.2.x, so we assumed it would be the latest MRI version.

@jtarchie
Copy link
Author

@donv: We've added a bit of coverage to bundler to support version operators. Would love to have a second pair of eyes review it.

@donv
Copy link
Member

donv commented Oct 31, 2015

@jtarchie Will take a look.

@donv
Copy link
Member

donv commented Oct 31, 2015

@jtarchie Looks good to me. 👍

@enebo enebo added this to the Invalid or Duplicate milestone Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants