Update ghp import #2152
Merged
Update ghp import #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We don’t have any tests for |
|
I'm not aware of changes, but neither have I exercised any related code. Perhaps you can find someone who uses github pages, and get them to run some tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my use on OSX, python3, there were encoding issues in setup.py for the older ghp-import during pip install. ghp-import2 is supposed to fix that and other packaging issues so I'm hoping you can upgrade.
I've made the appropriate change in requirements-extras.txt, and tried to run tests. I immediately hit a problem related to parsing the results of
locale -a, which are different on OSX, so fixed that issue.I see other test failures due to temporary directories ('/var/folders') and hyphenator.
Can you test this PR in your environment, and merge it if it works for you. Sorry, don't have time to fix anymore tests at the moment.