Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Truffle] fix MultibyteCharsUTF8Behaviour related bugs to let activesupport pass #3416

Closed
pitr-ch opened this issue Oct 22, 2015 · 4 comments
Closed

[Truffle] fix MultibyteCharsUTF8Behaviour related bugs to let activesupport pass #3416

pitr-ch opened this issue Oct 22, 2015 · 4 comments
Assignees
@nirvdrum
Milestone
Non-Release

Comments

@pitr-ch
Copy link
Member

pitr-ch commented Oct 22, 2015

please see https://gist.github.com/pitr-ch/1dc387164294bb23459b#file-test-log-L58-L147
@pitr-ch pitr-ch added this to the truffe milestone Oct 22, 2015
@chrisseaton
Copy link
Contributor

I think the underlying problem here is that we seem to be leaking a Java String into the Ruby data flow graph.

@nirvdrum
Copy link
Contributor

nirvdrum commented Nov 7, 2015

I fixed the Java String leak. It was a bad refactoring on the Kernel#method work I was doing. I think the remaining multibyte char tests are failing due to a difference in Marshal.load.

@pitr-ch
Copy link
Member Author

pitr-ch commented Nov 23, 2015

Thanks for the fix, @nirvdrum Could you look at the remaining issues? (3 errors)

@chrisseaton chrisseaton modified the milestones: truffe, truffle, truffle-dev Dec 19, 2015
@pitr-ch
Copy link
Member Author

pitr-ch commented Mar 7, 2016

tracked in #3543

@pitr-ch pitr-ch closed this as completed Mar 7, 2016
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nirvdrum nirvdrum

Labels
None yet
Projects
None yet
Milestone
Non-Release
Development

No branches or pull requests
4 participants
@nirvdrum @enebo @pitr-ch @chrisseaton