Wrap direct bytes for UDPSocket#send, to avoid copying. Fix #621.

jruby · Apr 5, 2016 · 2221210 · 2221210
1 parent 90f7ad6
commit 2221210
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/core/src/main/java/org/jruby/ext/socket/RubyUDPSocket.java b/core/src/main/java/org/jruby/ext/socket/RubyUDPSocket.java
@@ -276,7 +276,8 @@ public IRubyObject send(ThreadContext context, IRubyObject _mesg, IRubyObject _f
             int written;
 
             RubyString data = _mesg.convertToString();
-            ByteBuffer buf = ByteBuffer.wrap(data.getBytes());
+            ByteList dataBL = data.getByteList();
+            ByteBuffer buf = ByteBuffer.wrap(dataBL.unsafeBytes(), dataBL.begin(), dataBL.realSize());
 
             written = ((DatagramChannel) this.getChannel()).write(buf);
 
@@ -321,7 +322,8 @@ public IRubyObject send(ThreadContext context, IRubyObject[] args) {
 
             RubyString nameStr = _host.convertToString();
             RubyString data = _mesg.convertToString();
-            ByteBuffer buf = ByteBuffer.wrap(data.getBytes());
+            ByteList dataBL = data.getByteList();
+            ByteBuffer buf = ByteBuffer.wrap(dataBL.unsafeBytes(), dataBL.begin(), dataBL.realSize());
 
             byte[] buf2 = data.getBytes();
             DatagramPacket sendDP;