Moved <footer>outside of <div role='main'>
#2316
Conversation
This enhances accessibility, particularly because a footer is not part of the main content of the page. Fixes #2309
|
Bootstrap itself mixes it in their examples… would you mind complaining there first? |
|
The test failure is in the invariant build. The test should be updated with this PR. The test is checking the html output, and comparing it to a per-modification version; you just have to make the same change to the test that you made to the templates. |
|
The test failure cannot be averted by contributors and needs to be handled by a core dev (who has access to the invariant-builds repo, which introduces a race-condition) |
|
Oh. I didn't know that part. At least it is documented why the one travis build is failing then. |
|
Okay, so I have filed an issue, and they are willing to fix it. The On 09/04/2016 16:21, Chris Warrick wrote:
|
|
footer within div#container: https://getbootstrap.com/examples/jumbotron/ or https://getbootstrap.com/examples/carousel/ footer outside of div#container: https://getbootstrap.com/examples/blog/ or https://getbootstrap.com/examples/sticky-footer/ Looking closer, it might just be intentional for styling and not for accessibility. If you moved But thanks for caring! |
|
OK, thanks for the info. |
|
Looking through old issues, I see that this was rejected in Bootstrap's side (see twbs/bootstrap#19730). So... May I ask you to reconsider this? Thank you very much. |
|
If they won’t fix it, we also have no reason to. Fix it in your custom templates. |
This enhances accessibility, particularly because a footer is not part of
the main content of the page.
Fixes #2309
By the way, I didn't Jinjify the result, because I tried, and a lot of whitespace changes (evil ^m on Windows) apeared everywhere as a result. So I thought you'd prefer a cleaner diff.