Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IO.copy_streams are not closing filename argument IO instances. #3766

Closed
enebo opened this issue Mar 29, 2016 · 0 comments
Closed

IO.copy_streams are not closing filename argument IO instances. #3766

enebo opened this issue Mar 29, 2016 · 0 comments
Labels
windows
Milestone
JRuby 1.7.25

Comments

@enebo
Copy link
Member

enebo commented Mar 29, 2016

Environment

JRuby 1.7.25 (not sure about 9k but it will be another issue if so)

Expected Behavior

On windows ruby/spec will fail because it is trying to delete files in which an open IO object is still keep the file open. Because windows cannot delete any file which is already open then this is undesirable.

Actual Behavior

We hork...

This issue is not really noticed on non-windows machines so I marked this against windows but for non-IO passed in arguments this could potentially starve a process out of all available file descriptors. So it really affects all systems. It is just super apparent on windows :)
@enebo enebo added the windows label Mar 29, 2016
@enebo enebo added this to the JRuby 1.7.25 milestone Mar 29, 2016
enebo added a commit that referenced this issue Mar 29, 2016
@enebo
Fixes #3766. IO.copy_streams are not closing filename argument IO

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
04b8191 
instances.

Solution is to close any open IO instances which were not passed in
as actual IO instances.
@enebo enebo closed this as completed Mar 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
windows
Projects
None yet
Milestone
JRuby 1.7.25
Development

No branches or pull requests
1 participant
@enebo