[5.1] Fix Str::snake method for UTF-8 strings #12923
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks |
|
Any chance we could have a test added here too please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When i set locale to
tr_TR.UTF-8, Str::snake() method can't convert an utf-8 string to snake case correctly because ofstrtolower. So in SQL queries, it causes query exceptions:In this example, it is trying to get Laravel Eloquent model called
Invite's data but it's table name converted toInvitesinstead ofinvites. When i set table name manually to model ($tableproperty), it works.NOTE: This issue occurs on PHP 7 setup.