New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch/cxsmiles read #200
Patch/cxsmiles read #200
Conversation
johnmay
commented
Mar 29, 2016
- A few patches on rendering that we left behind from another branch.
- Read CXSMILES layers and set information in CDK data-structures (Main part).
…ulenes and azides.
… any ionic bonds we temporarily add in..
BTW, what is a CXSMILES? |
CXSMILES (ChemAxon Extended SMILES) is layers of info in the SMILES title that add additional semantics - think of it like an InChI AuxInfo but unlike the AuxInfo you can still canonicalise it.
It allows the extension of SMILES to support additional features whilst maintaining backwards compatibility. Indigo (GGA/EPAM) already have support for some features such as fragment grouping and atom labels. From discussions with a former ChemAxon dev, it wasn't intended for external consumption and just for JChemBase. Despite some horrid syntax (reusing ',' for field and record separation) it is actually quite useful. Projects such as HELM use the atom-labels (although they could have done that another way). |
Did you create an IChemFormat subclassing the SMILESFormat? |
They're not really a different format. Every CXSMILES is a valid SMILES. Would you consider reactions SMILES and SMILES different? It's perfectly valid to mix these in a single file:
|
If every CXSMILES is indeed a valid SMILES, then it's fine, I guess... yet, not every full SMILES parser may parse full CXSMILES, I guess? But if any SMILES parser will safely ignore the CX bits, then it should indeed be no problem. |
Yep, the coordinate output will be very useful. I've previously documented how to do it in a custom way in the JavaDoc of SmilesGenerator but have a more portable way makes this much easier. |
…of the arrow head.
…action. We use a new property which is picked up during the depiction generation. Some minor tweaks were made to sizing calculations in particular ensuring -1 is not used which was accidentally making some spacing smaller then needed.
Cool thanks, do you have any commits pending? Otherwise I think it's time for a release. |
No, but the next two weeks I'm taking a number of days off and plan to work on the CDK paper and possible my CDK book... that will likely results in some patches, but that's fine for a later release. |