Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: foswiki/distro
base: cd7968944c47
Choose a base ref
...
head repository: foswiki/distro
compare: 49d7837f56ed
Choose a head ref
  • 3 commits
  • 7 files changed
  • 1 contributor

Commits on Mar 31, 2016

  1. Item13989: Allow selected topics to get guest sessions. 

    This adds a new context:  sessionRequired,  which is set for scripts and
topics that can't be used without a CGI session, for ex. pages that
submit forms using StrikeOne validation, like UserRegistration.

This also makes a minor change in the order that objects are created
during Foswiki initialization.  The Foswiki->new() session object is
moved down past parsing of the query path, so that the topic is
determined before the session is created.

Needed to change the RegisterTests,  as several of them ran "register"
and "reset password" from the WebHome topic, which would not normally be
done.  Alcso ManageDotPm and CommentPlugin tests need sessions.

Also disable the override for GuestSessions in FoswikiTestCase,  with
these changes, tests should run with sessions disabled.
    @gac410
    gac410 committed Mar 31, 2016
    Copy the full SHA
    9bb3a99 View commit details
    Browse the repository at this point in the history

  2. Item13989: Make guest sessions a bit more persistent 

    If a user gets a guest session by visiting a page that requires
sessions, allow it to become persistent.  This means we don't need
SwitchBoard to set the sessionRequired context.

The cleanup code needs to be moved into the logout processing, so that
sessions are deleted when logging out.

Also fix a bug in Registration.   Register called
LoginManager::userLoggedIn() to cause the session to switch to the newly
registered user,  but this was not sticking.  userLoggedIn needs to add
the newly created cookie into the response.
    @gac410
    gac410 committed Mar 31, 2016
    Copy the full SHA
    96d3f39 View commit details
    Browse the repository at this point in the history

  3. Item13989: remove extraneous commas 

    They are valid, not needed.
    @gac410
    gac410 committed Mar 31, 2016
    Copy the full SHA
    49d7837 View commit details
    Browse the repository at this point in the history