[5.2] Add Filesystem tests. #12940
Merged
[5.2] Add Filesystem tests. #12940
+36
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -324,4 +324,40 @@ public function testSharedGet() | |||
| $this->assertTrue($result === 1); | |||
| @unlink(__DIR__.'/file.txt'); | |||
| } | |||
|
|
|||
| public function testRequireOnceRequiresFileProperly() | |||
There was a problem hiding this comment.
This test will break if you run phpunit with multiple runs
There was a problem hiding this comment.
Or rather, it won't really test anything properly.
There was a problem hiding this comment.
You should call requireOnce more than one to check it only requires the file once.
| file_put_contents(__DIR__.'/foo/foo.txt', 'contents'); | ||
| $this->assertTrue($filesystem->isFile(__DIR__.'/foo/foo.txt')); | ||
| $this->assertFalse($filesystem->isFile(__DIR__.'./foo')); | ||
| @unlink('/foo/foo.txt'); |
There was a problem hiding this comment.
This line should be:
@unlink(__DIR__ . '/foo/foo.txt');Currently, this leaves tests/Filesystem/foo/foo.txt lying around and this breaks several tests if the test suite is run a second time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 3 tests for previously untested Filesystems requireOnce, copy and isFile methods.