Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rubinius/rubinius
base: 97c331d2a7b7
Choose a base ref
...
head repository: rubinius/rubinius
compare: cdb05eafb63e
Choose a head ref
  • 19 commits
  • 4 files changed
  • 2 contributors

Commits on Jun 13, 2015

  1. Adds Numeric#step keyword arguments specs. 

    The implementation moves the specs that applies to all modes
(positional arguments, keyword arguments and mixed arguments) to a
shared spec file.
The specific code is maintained on the main Numeric#step spec file.
    @fmfdias
    fmfdias committed Jun 13, 2015
    Copy the full SHA
    0c056f2 View commit details
    Browse the repository at this point in the history

  2. Implements keyword arguments on Numeric#step.

    @fmfdias
    fmfdias committed Jun 13, 2015
    Copy the full SHA
    bf2d9cd View commit details
    Browse the repository at this point in the history

  3. Move get_args method to a helper file.

    @fmfdias
    fmfdias committed Jun 13, 2015
    Copy the full SHA
    d6ad6c3 View commit details
    Browse the repository at this point in the history

  4. Removes unneeded parenthesis from an if.

    @fmfdias
    fmfdias committed Jun 13, 2015
    Copy the full SHA
    e6f251a View commit details
    Browse the repository at this point in the history

  5. Switch from be_kind_of to be_an_instance_of.

    @fmfdias
    fmfdias committed Jun 13, 2015
    Copy the full SHA
    83eb732 View commit details
    Browse the repository at this point in the history

  6. Removes specs that only test implementation details.

    @fmfdias
    fmfdias committed Jun 13, 2015
    Copy the full SHA
    7a2f858 View commit details
    Browse the repository at this point in the history

  7. First take at the Numeric#step spec reorganization.

    @fmfdias
    fmfdias committed Jun 13, 2015
    Copy the full SHA
    0e2be45 View commit details
    Browse the repository at this point in the history

  8. Avoid false positive due to type conversions on Numeric types.

    @fmfdias
    fmfdias committed Jun 13, 2015
    Copy the full SHA
    c2f4895 View commit details
    Browse the repository at this point in the history

  9. Restructure step as string specs

    @fmfdias
    fmfdias committed Jun 13, 2015
    Copy the full SHA
    b212953 View commit details
    Browse the repository at this point in the history

  10. Adds more specs and fix a spec text.

    @fmfdias
    fmfdias committed Jun 13, 2015
    Copy the full SHA
    fde6a01 View commit details
    Browse the repository at this point in the history

  11. Use value instead of self. 

    When one the params is a float, the results are floats.
    @fmfdias
    fmfdias committed Jun 13, 2015
    Copy the full SHA
    3f39c32 View commit details
    Browse the repository at this point in the history

  12. Replace Float::INFINITY value by infinity_value helper.

    @fmfdias
    fmfdias committed Jun 13, 2015
    Copy the full SHA
    469b904 View commit details
    Browse the repository at this point in the history

  13. Remove ruby_bug guards

    @fmfdias
    fmfdias committed Jun 13, 2015
    Copy the full SHA
    51a278b View commit details
    Browse the repository at this point in the history

  14. Apply another approach to share the specs for different argument types.

    @fmfdias
    fmfdias committed Jun 13, 2015
    Copy the full SHA
    c9068fc View commit details
    Browse the repository at this point in the history

  15. Adds an extra test to the keywords argument style.

    @fmfdias
    fmfdias committed Jun 13, 2015
    Copy the full SHA
    9aec8f8 View commit details
    Browse the repository at this point in the history

  16. Improve shared spec comment.

    @fmfdias
    fmfdias committed Jun 13, 2015
    Copy the full SHA
    02ad34c View commit details
    Browse the repository at this point in the history

  17. Improve test description to avoid misinterpretation.

    @fmfdias
    fmfdias committed Jun 13, 2015
    Copy the full SHA
    bd606b5 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2016

  1. Merge branch 'add_numeric_step_kw_args' of https://github.com/fmfdias… 

    …/rubinius into fmfdias-add_numeric_step_kw_args
    @brixen
    brixen committed Apr 6, 2016
    Copy the full SHA
    20ff1eb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fmfdias-add_numeric_step_kw_args'

    @brixen
    brixen committed Apr 6, 2016
    Copy the full SHA
    cdb05ea View commit details
    Browse the repository at this point in the history