Skip to content

Commit

Permalink
gui: setParent(None) before deleteLater() to remove dock appears unne…
Browse files Browse the repository at this point in the history
…cessary and causes memory corruption on Windows. Closes #362
sbourdeauducq committed Mar 30, 2016

Unverified

No user is associated with the committer email.
1 parent 72da5cc commit 06e6260
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion artiq/gui/applets.py
Original file line number Diff line number Diff line change
@@ -167,7 +167,6 @@ async def terminate(self, delete_self=True):
self.starting_stopping = False

if delete_self:
self.setParent(None)
self.deleteLater()

async def restart(self):
1 change: 0 additions & 1 deletion artiq/gui/log.py
Original file line number Diff line number Diff line change
@@ -356,7 +356,6 @@ def create_new_dock(self, add_to_area=True):

def on_dock_closed(self, name):
dock = self.docks[name]
dock.setParent(None)
dock.deleteLater()
del self.docks[name]
self.update_closable()

0 comments on commit 06e6260

Please sign in to comment.