Skip to content

Commit 06e6260

Browse files
committedMar 30, 2016
gui: setParent(None) before deleteLater() to remove dock appears unnecessary and causes memory corruption on Windows. Closes #362
1 parent 72da5cc commit 06e6260

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed
 

Diff for: ‎artiq/gui/applets.py

-1
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,6 @@ async def terminate(self, delete_self=True):
167167
self.starting_stopping = False
168168

169169
if delete_self:
170-
self.setParent(None)
171170
self.deleteLater()
172171

173172
async def restart(self):

Diff for: ‎artiq/gui/log.py

-1
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,6 @@ def create_new_dock(self, add_to_area=True):
356356

357357
def on_dock_closed(self, name):
358358
dock = self.docks[name]
359-
dock.setParent(None)
360359
dock.deleteLater()
361360
del self.docks[name]
362361
self.update_closable()

0 commit comments

Comments
 (0)
Please sign in to comment.