Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaitReadable/Writable exceptions generate backtraces #55

Closed
headius opened this issue Jul 19, 2015 · 2 comments
Closed

WaitReadable/Writable exceptions generate backtraces #55

headius opened this issue Jul 19, 2015 · 2 comments
Labels

Comments

@headius
Copy link
Member

headius commented Jul 19, 2015

When waiting for the underlying stream to be ready for read or write, SSLSocket causes WaitReadable and WaitWritable versions of SSLError to be raised. These exceptions are generating full backtraces every time, which greatly reduces the performance of these nonblocking IO calls.

I have a small patch that disables the backtraces for Readable, but we'll want to do something configurable and a bit cleaner than this: https://gist.github.com/headius/1900d41e760821fbedf8

It may also be possible to eliminate the need to raise this Ruby error if it is only happening within internal code; specifically, if we are calling into the waitReadable/Writable logic from Java code and capturing the result, there's no reason to raise a full Ruby error.

@kares
Copy link
Member

kares commented Nov 25, 2015

looked into this - stumbled across unable to force a nil bracktrace: plese review jruby/jruby#3488

@kares
Copy link
Member

kares commented Mar 30, 2016

working since 0.9.15 ... also respects getProperty("jruby.errno.backtrace", "false")

@kares kares closed this as completed Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants