let Mojo::JSON generate canonical JSON objects again (closes #665)

mojolicious · Apr 1, 2016 · 5f47058 · 5f47058
1 parent 68d434c
commit 5f47058
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/Changes b/Changes
@@ -1,6 +1,7 @@
 
-6.58  2016-03-31
+6.58  2016-04-02
   - Added fork policy to Mojolicious::Guides::Contributing.
+  - Improved Mojo::JSON to generate canonical JSON objects.
 
 6.57  2016-03-23
   - Fixed a few validation bugs in Mojolicious::Validator::Validation.

diff --git a/lib/Mojo/JSON.pm b/lib/Mojo/JSON.pm
@@ -213,7 +213,7 @@ sub _encode_array {
 sub _encode_object {
   my $object = shift;
   my @pairs = map { _encode_string($_) . ':' . _encode_value($object->{$_}) }
-    keys %$object;
+    sort keys %$object;
   return '{' . join(',', @pairs) . '}';
 }
 

diff --git a/t/mojo/json.t b/t/mojo/json.t
@@ -168,6 +168,9 @@ $bytes = encode_json {foo => []};
 is $bytes, '{"foo":[]}', 'encode {foo => []}';
 $bytes = encode_json {foo => ['bar']};
 is $bytes, '{"foo":["bar"]}', 'encode {foo => [\'bar\']}';
+$bytes = encode_json {foo => 'bar', baz => 'yada'};
+is $bytes, '{"baz":"yada","foo":"bar"}',
+  'encode {foo => \'bar\', baz => \'yada\'}';
 
 # Encode name
 $bytes = encode_json [Mojo::JSON->true];