Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestParse#test_named_capture_conflict #2147

Closed
headius opened this issue Nov 7, 2014 · 2 comments
Closed

TestParse#test_named_capture_conflict #2147

headius opened this issue Nov 7, 2014 · 2 comments
Labels
parser
Milestone
JRuby 9.1.0.0

Comments

@headius
Copy link
Member

headius commented Nov 7, 2014

Here's the failures:

[4130/5912] TestParse#test_named_capture_conflict = 0.00 s                                 
 36) Failure:
TestParse#test_named_capture_conflict [/Users/headius/projects/jruby/test/mri/ruby/test_parse.rb:870]:
Expected: /named capture conflict/
  Actual: "".

And here's the MRI commit for the tests at least: ruby/ruby@5129155

I did not see the commit where they added these warnings. It could have been a long time ago, and they just started testing it recently.
@headius headius added the parser label Nov 7, 2014
@headius headius added this to the JRuby 9.0.0.0 milestone Nov 7, 2014
@headius
Copy link
Member Author

headius commented Nov 7, 2014

Oops, committed with wrong message. Excludes are in 54eace2.

@headius headius mentioned this issue Nov 7, 2014
Closed
@enebo enebo modified the milestone: JRuby 9.0.0.0 Jul 14, 2015
@enebo enebo changed the title Missing parser warnings for 2.2 TestParse#test_named_capture_conflict Apr 1, 2016
@enebo
Copy link
Member

enebo commented Apr 1, 2016

Made new issue for the unused variable which surprisingly is much more work since it require use/def accounting.

@enebo enebo closed this as completed in f1ead40 Apr 1, 2016
@enebo enebo added this to the JRuby 9.1.0.0 milestone Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
parser
Projects
None yet
Milestone
JRuby 9.1.0.0
Development

No branches or pull requests
2 participants
@headius @enebo