Avoid leaking orphaned VM instances.

brixen · brixen · commit 045796e39b74 · 2016-03-26T19:59:17.000-07:00
When starting a Thread, there is a point where resources are created but an
exception could be raised that would result in the resources not getting
reclaimed. At the moment, this is the VM instance. This will be refactored
soon, but the same caution will always apply to creating Thread instances.
diff --git a/machine/builtin/thread.cpp b/machine/builtin/thread.cpp
@@ -156,6 +156,7 @@ namespace rubinius {
         call_frame->line(state));
 
     if(!thread->send(state, state->symbol("initialize"), args, block, true)) {
+      thread->vm()->set_zombie(state);
       return NULL;
     }
 
@@ -175,6 +176,7 @@ namespace rubinius {
         call_frame->line(state));
 
     if(!thread->send(state, state->symbol("__thread_initialize__"), args, block, true)) {
+      thread->vm()->set_zombie(state);
       return NULL;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -156,6 +156,7 @@ namespace rubinius {`
`156`	`156`	`call_frame->line(state));`
`157`	`157`
`158`	`158`	`if(!thread->send(state, state->symbol("initialize"), args, block, true)) {`
	`159`	`+ thread->vm()->set_zombie(state);`
`159`	`160`	`return NULL;`
`160`	`161`	`}`
`161`	`162`
`@@ -175,6 +176,7 @@ namespace rubinius {`
`175`	`176`	`call_frame->line(state));`
`176`	`177`
`177`	`178`	`if(!thread->send(state, state->symbol("__thread_initialize__"), args, block, true)) {`
	`179`	`+ thread->vm()->set_zombie(state);`
`178`	`180`	`return NULL;`
`179`	`181`	`}`
`180`	`182`