Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should not convert URI paths to backslashes on windows...ever #3771

Open
enebo opened this issue Mar 31, 2016 · 0 comments
Open

We should not convert URI paths to backslashes on windows...ever #3771

enebo opened this issue Mar 31, 2016 · 0 comments
Labels
windows

Comments

@enebo
Copy link
Member

enebo commented Mar 31, 2016

Environment

JRuby 9.0.5.0 and 1.7.24

Expected Behavior

File.expand_path("uri:classloader:////foo/b.gemspec") #=> "uri:classloader:/foo/b.gemspec"

Actual Behavior

"uri:classloader:\foo\b.gemspec"

I suspect this is more than just expand_path since we liter this uri-handling logic in several places but we should never be renormalizing to backslash paths for any uri.
@enebo enebo added the windows label Mar 31, 2016
@enebo enebo added this to the JRuby 1.7.26 milestone Mar 31, 2016
enebo added a commit that referenced this issue Mar 31, 2016
@enebo
Comment out failing spec with reference to tracking issue #3771 (back…

Verified

This commit was signed with the committer’s verified signature.
makenowjust Hiroya Fujinami
GPG key ID: 9F4CB6A0CB6B6BE9
Verified
Learn about vigilant mode
a9e3f89 
…slashes in URIs)
@mkristian mkristian mentioned this issue May 12, 2016
Open
@enebo enebo modified the milestones: JRuby 1.7.26, JRuby 1.7.27 Aug 26, 2016
@enebo enebo removed this from the JRuby 1.7.27 milestone Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@enebo