Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AppVeyor tests on 64-bit Java on Windows as well. #3774

Closed
wants to merge 1 commit into from

Conversation

perlun
Copy link
Contributor

@perlun perlun commented Apr 1, 2016

It was already enabled on the master branch, but not here.

Side note: Should we also add the ant MRI tests on master? I noted that it was only enabled in the jruby-1_7 branch, but not in the appveyor.yml on master.

(@enebo - I happened to see this after your comment in #3767)

It was already enabled on the master branch, but not here.

Side note: Should we also add the ant MRI tests on master? I noted that it was only enabled in the jruby-1_7 branch, but not in the appveyor.yml on master.
@perlun perlun changed the title Enable tests on 64-bit Java on Windows as well. Enable AppVeyor tests on 64-bit Java on Windows as well. Apr 1, 2016
@enebo enebo added this to the Invalid or Duplicate milestone Apr 2, 2016
@enebo
Copy link
Member

enebo commented Apr 2, 2016

@perlun 64 bit is currently disabled because our current native launcher only can in-process launch the JVM in 32 bit mores. In 64 JVM it fails and the launcher falls back to launching Java via the command-line. We have an open bug on windows (I don't recall number offhand) which covers the fact that we improperly quote in the native launcher in the presence of quotes. This causes many tests to fail which invoke sub-procs of JRuby. We also have no ability to skip tests based on VM arch type (32 v 64) so I disabled running on 64 bit JVMs until we upgrade mjruby into jruby-launcher project.

Whew...a lot of explanation for why I am not merging this today :) It will be added in once we update jruby-launcher.

@enebo enebo closed this Apr 2, 2016
@perlun
Copy link
Contributor Author

perlun commented Apr 3, 2016

Whew...a lot of explanation for why I am not merging this today :) It will be added in once we update jruby-launcher.

Hehe, ok! Thanks for taking the time to explain the "why's" behind this.

@perlun perlun deleted the update-appveyor-on-1-7-branch branch April 3, 2016 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants