You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Because we can't open a file in text mode on Windows (Java has no such concept) we currently force read/write conversion to use UNIVERSAL_NEWLINE_DECORATOR. Your example, explicitly tries to turn that mode off, but since we're on Windows doing text mode it gets turned back on again.
So we need a way to propagate that universal newlines were explicitly disabled and not turn them on for text mode in that case.
It may be the case that existing processing of textmode during ecflags handling is doing everything we need. Inside EncodingUtils.extractModeEncoding I see it setting universal newline whenever we're in textmode, but with an eye for incoming options overriding that. Investigating.
Duplicated from #3736 for 9k specific work.
Environment
both jruby 1.7.24 and JRuby 9.0.5.0 have this issue.
Expected Behavior
A file which contains \r\n should still retain the \r\n and not convert to \n if universal_newline is false.
Actual Behavior
We seem to always return \n as delimiter.
The text was updated successfully, but these errors were encountered: