-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r8168: init at 8.041.01 #14274
r8168: init at 8.041.01 #14274
Conversation
Breaking on kernel 4.5 due to missing NETIF_F_ALL_CSUM (renamed to NETIF_F_CSUM_MASK, per https://lwn.net/Articles/667786/). I'll look into making a patch or disabling for 4.5. |
Actually I wouldn't be shocked if this package wasn't needed for kernel 4.5. The r8169 might be more stable in later kernel versions. |
cc @edolstra |
@sheenobu have you had the opportunity to test kernel v4.5? I'm unsure when 4.5 will become the default, so I think including a more recent version of the driver makes sense in the interim, if it is semi-broken in older kernel versions. |
@joachifm This is the newest r8168 driver. I'm shocked it even compiled for 4.x kernels at all. r8169 (the default) is the semi broken one, and this is just a replacement for those effected. I'll see about testing the defaults for kernel 4.5. If successful, this driver will only be necessary for kernels 4.3 and lower. |
4dfd87c
to
0b4b9df
Compare
@joachifm Was able to get it working with 4.5 via a patch. Tested building on 4.4 and 4.5, and have been using locally on 4.3. |
is 4.3 still a relevant kernel version? |
So the driver did not help to solve this issue? |
It solved it, temporarily. Eventually the issues came back with both On Sun, Oct 2, 2016, 2:18 AM Jörg Thalheim notifications@github.com wrote:
|
Is this still relevant? |
Things done:
nix-build --option build-use-chroot true
or nix.useChroot on NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)Please note, that points are not mandatory, but rather desired.
I get lots of issues with the r8169 on kernel 4.3.x . Decided to try out this driver. It's GPL2 but has some notes about patents within the source.
Would appreciate some feedback.