Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r8168: init at 8.041.01 #14274

Closed
wants to merge 1 commit into from
Closed

r8168: init at 8.041.01 #14274

wants to merge 1 commit into from

Conversation

sheenobu
Copy link
Contributor

@sheenobu sheenobu commented Mar 28, 2016

Things done:
  • Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Please note, that points are not mandatory, but rather desired.

I get lots of issues with the r8169 on kernel 4.3.x . Decided to try out this driver. It's GPL2 but has some notes about patents within the source.

Would appreciate some feedback.

@sheenobu
Copy link
Contributor Author

Breaking on kernel 4.5 due to missing NETIF_F_ALL_CSUM (renamed to NETIF_F_CSUM_MASK, per https://lwn.net/Articles/667786/). I'll look into making a patch or disabling for 4.5.

@sheenobu
Copy link
Contributor Author

Actually I wouldn't be shocked if this package wasn't needed for kernel 4.5. The r8169 might be more stable in later kernel versions.

@jagajaga
Copy link
Member

cc @edolstra

@joachifm
Copy link
Contributor

joachifm commented Apr 1, 2016

@sheenobu have you had the opportunity to test kernel v4.5? I'm unsure when 4.5 will become the default, so I think including a more recent version of the driver makes sense in the interim, if it is semi-broken in older kernel versions.

@sheenobu
Copy link
Contributor Author

sheenobu commented Apr 1, 2016

@joachifm This is the newest r8168 driver. I'm shocked it even compiled for 4.x kernels at all. r8169 (the default) is the semi broken one, and this is just a replacement for those effected. I'll see about testing the defaults for kernel 4.5. If successful, this driver will only be necessary for kernels 4.3 and lower.

@sheenobu sheenobu force-pushed the r8168_driver branch 3 times, most recently from 4dfd87c to 0b4b9df Compare April 18, 2016 21:40
@sheenobu
Copy link
Contributor Author

@joachifm Was able to get it working with 4.5 via a patch. Tested building on 4.4 and 4.5, and have been using locally on 4.3.

@Mic92
Copy link
Member

Mic92 commented Oct 1, 2016

is 4.3 still a relevant kernel version?

@sheenobu
Copy link
Contributor Author

sheenobu commented Oct 1, 2016

@Mic92 Looks like kernel 4.3 was removed in 16.03 1e1d6ec . The machine this patch was for still has ethernet issues (on 4.4.19 right now)

@Mic92
Copy link
Member

Mic92 commented Oct 2, 2016

So the driver did not help to solve this issue?

@sheenobu
Copy link
Contributor Author

sheenobu commented Oct 2, 2016

It solved it, temporarily. Eventually the issues came back with both
builtin 4.4 drivers and this driver. I haven't been able to find a cause.

On Sun, Oct 2, 2016, 2:18 AM Jörg Thalheim notifications@github.com wrote:

So the driver did not help to solve this issue?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14274 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABYGgwtwSbHEqybjeqc-J6_ylbc_9vBAks5qv0yggaJpZM4H5-ed
.

Sheena Artrip
http://sheenobu.net

@joachifm
Copy link
Contributor

Is this still relevant?

@joachifm joachifm closed this Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants