-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unicode chars in method names aren't accepted #3778
Comments
It seems to be seeing The send issue is a known mismatch between how we store multibyte symbols and how we store methods. |
@jodosha also extreme minor issue I should bring up it we recently learned multibyte methods defined in irb will not work (@donv opened an issue on that a couple of days ago -- #4070). That is not related to this issue at all but you might trip over that as well. The send issue and most likely the last of our encoding issues should be addressed by: #3880 (comment) This is a big change and we need to do it early in a dev cycle for bake time. |
I think the main issue here above and beyond #3880 is that
So whatever the parser is using to determine capital letters for constants, it's not handling this MBC properly. |
Oh, and I agree this isn't going to make 9.1.3.0, so punting. |
@jodosha The comment explains this but it was pretty simple to fix and I feel this is not risky so this is in 9.1.3.0. The send with a string is still broken but a different issue (alluded to in my previous comment). |
Environment
JRuby version:
jruby 9.1.0.0-SNAPSHOT (2.3.0) 2016-04-01 30c1276 Java HotSpot(TM) 64-Bit Server VM 25.60-b23 on 1.8.0_60-b27 +jit [darwin-x86_64]
OS:
Darwin escher 15.3.0 Darwin Kernel Version 15.3.0: Thu Dec 10 18:40:58 PST 2015; root:xnu-3248.30.4~1/RELEASE_X86_64 x86_64
Expected Behavior
Unicode chars in method names should be accepted.
I discovered this issue with
hanami-utils
and patched it to make the build to pass with 9.0.0.0.According to @enebo, this supposed to be fixed with nightly series, but it isn't the case.
MRI/expected behavior:
Actual Behavior
The text was updated successfully, but these errors were encountered: