cloud9: init at 1.0.0-alpha #14437
Closed
cloud9: init at 1.0.0-alpha #14437
+95
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,93 @@ | |||
| { stdenv ? (import <nixpkgs> {}).stdenv | |||
There was a problem hiding this comment.
Please don't do import <nixpkgs>{} within a package expression.
| ln -s ${nan}/lib/node_modules/nan/ node_modules/nan[ | ||
| # npm install -g --prefix=$out | ||
| # npm install --prefix=$out https://github.com/c9/nak/tarball/c9 | ||
| ./scripts/install-sdk.sh # totally impure!, 64 packages to add |
There was a problem hiding this comment.
This is the major part which I would like to improve. I don't use the buildNodePackages because there is some retrieval of additional 64 packages and a bit of other setup that this script runs. I would like to simply use buildNodePackages, with minor edits if possible.
joachifm
added
2.status: work-in-progress
|
Closing due to age, we can re-open :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done:
nix-build --option build-use-chroot trueor nix.useChroot on NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)More
I am not very familiar with NPM packaging and this also seems to be a non-standard packaging setup. I would welcome any help to figure out a way to use the proper build tools. I did test this and it works as a service on NixOS.