Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b97e35bf4606^
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6df7e042f450
Choose a head ref
  • 3 commits
  • 5 files changed
  • 1 contributor

Commits on Apr 4, 2016

  1. dry-out (generated) temp var base-index calculation + minor Ruby clas… 

    …s reify cleanup
    @kares
    kares committed Apr 4, 2016
    Copy the full SHA
    b97e35b View commit details

  2. [ji] refactor Ruby class reify to generate more accurate (arity match… 

    …ing) signatures

previously all method arities ended up as var-args : `foo(IRubyObject[] args)`

now for fixed arities we'll have correct number of args e.g. `foo(IRubyObject arg1)`
... we still generate var-args: `foo(IRubyObject[] args)` for all non-fixed arity sizes!

resolves #3206 and likely #449 also #3366 (java_signature is now honored)
    @kares
    kares committed Apr 4, 2016

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    eb7c236 View commit details

  3. [find-bugs] use char instead of string.length == 1

    @kares
    kares committed Apr 4, 2016
    Copy the full SHA
    6df7e04 View commit details
Loading