Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Ropes byte visitor #3785

Merged
merged 18 commits into from
Apr 7, 2016
Merged

[Truffle] Ropes byte visitor #3785

merged 18 commits into from
Apr 7, 2016

Conversation

chrisseaton
Copy link
Contributor

No description provided.


DigestLayoutImpl.INSTANCE.getDigest(digestObject).update(rope.getBytes(), rope.begin(), rope.byteLength());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the whole point of this PR - don't allocate the full byte[] to output it (or feed it into a digest function in this case).

@nirvdrum
Copy link
Contributor

nirvdrum commented Apr 7, 2016

A couple small comments. Otherwise, it looks good.

@chrisseaton chrisseaton merged commit 69132ce into master Apr 7, 2016
@chrisseaton chrisseaton deleted the truffle-ropes-visitor branch April 7, 2016 21:27
@enebo enebo modified the milestone: Non-Release May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants