-
-
Notifications
You must be signed in to change notification settings - Fork 925
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed #3786. File.dirname is munching too much off on an UNC pathname
Showing
3 changed files
with
48 additions
and
76 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1 @@ | ||
windows(JRUBY-4523):File.dirname returns all the components of filename except the last one (edge cases on windows) | ||
windows(JRUBY-4523):File.dirname returns the return all the components of filename except the last one (windows unc) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
windows(JRUBY-4523):File.dirname returns all the components of filename except the last one (edge cases on windows) | ||
windows(JRUBY-4523):File.dirname returns the return all the components of filename except the last one (windows unc) | ||
|
2 comments
on commit 137a315
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems 👍 ... merging to master shall tell since ci is less 🔴
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍭 but there's likely to be only 1 trailing '/' or '' thus 👌