[5.2] Create Authorize middleware and AuthorizesResources trait #12913

JosephSilber · 2016-03-29T12:23:52Z

1. A new `Authorize` middleware

Can be used with a simple ability:

Route::group(['middleware' => 'can:access-dashboard'], function () {
    // Dashboard routes...
});

Can be used on a single model:

Route::get('users/{user}', 'UserController@show')->middleware('can:view,user');

It will pull the $user model from the route.

Finally, it can be used on a model type:

Route::get('users', 'UserController@index')->middleware('can:view,'.User::class);

2. A new `AuthorizesResources` trait

class UsersController extends Controller
{
    public function __construct()
    {
        $this->authorizeResource('user', User::class);
    }
}

Will automatically add the correct middleware to authorize any request for the resource.

GrahamCampbell · 2016-03-29T12:24:41Z

src/Illuminate/Foundation/Auth/AuthorizesResources.php

+     * @param  string  $name
+     * @param  string  $model
+     * @param  array  $options
+     * @param  \Illuminate\Http\Request  $request


missing |null

mark86092 · 2016-03-30T07:18:20Z

src/Illuminate/Auth/Access/Middleware/Authorize.php

+     */
+    public function handle($request, Closure $next, $ability, $model = null)
+    {
+        $this->gate->authorize($ability, $this->getGateArguments($model));


getGateArguments($request, $model), missing $request ?

@mark86092 thanks for catching that!

Just goes to show that you always need tests. So I now wrote a test for the middleware too (it was originally in the laravel/laravel repo, which has no tests).

They've been merged into Laravel: laravel/framework#12913 For Laravel 5.1, here's some more information: #82

They've been merged into Laravel: laravel/framework#12913 For Laravel 5.1, here's some more information: JosephSilber/bouncer#82

GrahamCampbell reviewed Mar 29, 2016
View reviewed changes

JosephSilber force-pushed the authorizes-resources branch 2 times, most recently from 6e89bbd to 273f32f Compare March 30, 2016 01:18

JosephSilber changed the title ~~[5.2] Create AuthorizesResources trait~~ [5.2] Create Authorize middleware and AuthorizesResources trait Mar 30, 2016

JosephSilber force-pushed the authorizes-resources branch from be1532d to 9d47f39 Compare March 30, 2016 01:50

This was referenced Mar 30, 2016

Add support for the authorize middleware and AuthorizesRequests trait laravel/laravel#3723

Merged

Create an Authorize middleware laravel/laravel#3722

Closed

JosephSilber force-pushed the authorizes-resources branch from 9d47f39 to abdd9e0 Compare March 30, 2016 02:04

mark86092 reviewed Mar 30, 2016
View reviewed changes

Create Authorize middleware

648fa7e

JosephSilber force-pushed the authorizes-resources branch from abdd9e0 to 541d2b2 Compare March 30, 2016 13:27

Test the Authorize middleware

d32dd12

JosephSilber force-pushed the authorizes-resources branch from 541d2b2 to b9ce61c Compare March 30, 2016 14:21

JosephSilber added 2 commits March 30, 2016 10:45

Create AuthorizesResources trait

80bb82a

Test AuthorizesResources trait

6549156

JosephSilber force-pushed the authorizes-resources branch from b9ce61c to 6549156 Compare March 30, 2016 14:45

Move the Authorize middleware into Foundation

65907a6

taylorotwell merged commit 65907a6 into laravel:5.2 Apr 1, 2016

JosephSilber deleted the authorizes-resources branch April 3, 2016 15:23

JosephSilber restored the authorizes-resources branch April 3, 2016 15:27

JosephSilber deleted the authorizes-resources branch April 11, 2016 14:29

This was referenced Apr 11, 2016

Unable to use can: to protect routes JosephSilber/bouncer#81

Closed

Removing the Authorize middleware and the AuthorizesRequests trait JosephSilber/bouncer#82

Closed

JosephSilber added a commit to JosephSilber/bouncer that referenced this pull request Apr 17, 2016

Remove the Authorize middleware and AuthorizesResources trait

0c2ceaa

They've been merged into Laravel: laravel/framework#12913 For Laravel 5.1, here's some more information: #82

kunhalil mentioned this pull request Jun 17, 2016

Give multiple permissions in one go JosephSilber/bouncer#93

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[5.2] Create Authorize middleware and AuthorizesResources trait #12913

[5.2] Create Authorize middleware and AuthorizesResources trait #12913

JosephSilber commented Mar 29, 2016

GrahamCampbell Mar 29, 2016

mark86092 Mar 30, 2016

JosephSilber Mar 30, 2016

[5.2] Create Authorize middleware and AuthorizesResources trait #12913

[5.2] Create Authorize middleware and AuthorizesResources trait #12913

Conversation

JosephSilber commented Mar 29, 2016

1. A new Authorize middleware

2. A new AuthorizesResources trait

GrahamCampbell Mar 29, 2016

Choose a reason for hiding this comment

mark86092 Mar 30, 2016

Choose a reason for hiding this comment

JosephSilber Mar 30, 2016

Choose a reason for hiding this comment

1. A new `Authorize` middleware

2. A new `AuthorizesResources` trait