Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WARNING: SSLSocket#session= is not supported #3765

Closed
lolwhitaker opened this issue Mar 29, 2016 · 6 comments
Closed

WARNING: SSLSocket#session= is not supported #3765

lolwhitaker opened this issue Mar 29, 2016 · 6 comments
Labels
Milestone

Comments

@lolwhitaker
Copy link

Hello. I've seen this WARN log frequently in our builds during the bundler process as well as when using the net-http-persistent adapter running jruby 1.7.22.

WARNING: SSLSocket#session= is not supported

It looks like this was just not implemented. Its pretty annoying, but is it something I should be concerned about? I asked the same question in the jruby-openssl project but it was closed without any response.
#3635 also mentions this warning in 9.0.5.0...

jruby 1.7.22 (1.9.3p551) 2015-08-20 c28f492 on Java HotSpot(TM) 64-Bit Server VM 1.8.0_65-b17 +jit [darwin-x86_64]

@kares
Copy link
Member

kares commented Mar 29, 2016

opened: drbrain/net-http-persistent#72 to see what they think about removing ssl.session= on JRuby

@kares kares added this to the Won't Fix milestone Mar 29, 2016
@kares kares added the openssl label Mar 29, 2016
kares added a commit to jruby/jruby-openssl that referenced this issue Mar 30, 2016
…gine is setup

... hopefully the now removed `session=` warning won't confuse users as we do not
do much except for copy-ing the timeout - although the underlying engine should
now have an explicit hint not to create new sessions!

resolves cases such as jruby/jruby#3765
@suriyaa
Copy link

suriyaa commented Mar 31, 2016

👍

@dgolombek
Copy link

Since updating to 0.9.17-java we're now seeing problems trying to open sessions -- it looks like this change is probably to blame.

handle_connection_error: No existing session to resume: org/jruby/ext/openssl/SSLSocket.jav
a:217:in `connect'
/tmp/jetty-0.0.0.0-8080-evergreen.war-_evergreen-any-412843000765214245.dir/webapp/WEB-INF/gems/gems/net-http-persistent-2.9.4/lib/net/http/persistent/ssl_reuse.rb:70:in `connect'
org/jruby/ext/timeout/Timeout.java:115:in `timeout'
/tmp/jetty-0.0.0.0-8080-evergreen.war-_evergreen-any-412843000765214245.dir/webapp/WEB-INF/gems/gems/net-http-persistent-2.9.4/lib/net/http/persistent/ssl_reuse.rb:70:in `connect'
/tmp/jetty-0.0.0.0-8080-evergreen.war-_evergreen-any-412843000765214245.dir/webapp/WEB-INF/lib/jruby-stdlib-1.7.25.jar!/META-INF/jruby.home/lib/ruby/1.9/net/http.rb:756:in `do_start'
/tmp/jetty-0.0.0.0-8080-evergreen.war-_evergreen-any-412843000765214245.dir/webapp/WEB-INF/lib/jruby-stdlib-1.7.25.jar!/META-INF/jruby.home/lib/ruby/1.9/net/http.rb:751:in `start'
/tmp/jetty-0.0.0.0-8080-evergreen.war-_evergreen-any-412843000765214245.dir/webapp/WEB-INF/gems/gems/net-http-persistent-2.9.4/lib/net/http/persistent.rb:700:in `start'
/tmp/jetty-0.0.0.0-8080-evergreen.war-_evergreen-any-412843000765214245.dir/webapp/WEB-INF/gems/gems/net-http-persistent-2.9.4/lib/net/http/persistent.rb:965:in `reset'
/tmp/jetty-0.0.0.0-8080-evergreen.war-_evergreen-any-412843000765214245.dir/webapp/WEB-INF/gems/gems/net-http-persistent-2.9.4/lib/net/http/persistent.rb:628:in `connection_for'
/tmp/jetty-0.0.0.0-8080-evergreen.war-_evergreen-any-412843000765214245.dir/webapp/WEB-INF/gems/gems/net-http-persistent-2.9.4/lib/net/http/persistent.rb:994:in `request'
/tmp/jetty-0.0.0.0-8080-evergreen.war-_evergreen-any-412843000765214245.dir/webapp/WEB-INF/gems/gems/faraday-0.9.2/lib/faraday/adapter/net_http_persistent.rb:25:in `perform_request'
/tmp/jetty-0.0.0.0-8080-evergreen.war-_evergreen-any-412843000765214245.dir/webapp/WEB-INF/gems/gems/faraday-0.9.2/lib/faraday/adapter/net_http.rb:40:in `call'
/tmp/jetty-0.0.0.0-8080-evergreen.war-_evergreen-any-412843000765214245.dir/webapp/WEB-INF/gems/gems/faraday-0.9.2/lib/faraday/adapter/net_http_persistent.rb:21:in `with_net_http_connection'
/tmp/jetty-0.0.0.0-8080-evergreen.war-_evergreen-any-412843000765214245.dir/webapp/WEB-INF/gems/gems/faraday-0.9.2/lib/faraday/adapter/net_http.rb:32:in `call'

@dgolombek
Copy link

Created #3974

@headius
Copy link
Member

headius commented Jul 11, 2016

@kares Any progress on this? I was hoping we'd be able to ignore SSLSocket.session/= but perhaps we need to find a way to finish it.

@kares
Copy link
Member

kares commented Jul 12, 2016

it (kind of) is supported - was an empty stub up till 0.9.17 ... now it tries to force session re-use in 0.9.17.
... there seems to be some issues with the 0.9.17 change - waiting for feedback: jruby/jruby-openssl#97

@kares kares closed this as completed Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants