[5.2] Collection union function #12910
Merged
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
|
Please squash to one commit. |
|
Done :) |
|
Please fix the failing tests. |
|
@GrahamCampbell Something wrong with travis-ci. |
|
I'm just gonna link to this here: #12223 |
|
Fixed! Sorry about that - Travis seems to be having a headache generally but tests passed on PHP7 |
|
Travis seems to be up and down today. I've just given it another kick. |
|
Please rebase and force push, and that'll fix travis. |
|
Union sounds better than concat and the PHP docs to refer to the + operator on arrays as a "union". |
|
@john-main-croud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick function to provide a true union of two collections