-
-
Notifications
You must be signed in to change notification settings - Fork 925
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 79bbf323fd39
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 84265774f9a3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 2 commits
- 9 files changed
- 1 contributor
Commits on Apr 4, 2016
-
searchConst will not be going back to more primitive impl ever so cle…
…an up commented out code
Configuration menu - View commit details
-
Copy full SHA for ccb7706 - Browse repository at this point
Copy the full SHA ccb7706View commit details -
Hello new instr SearchModuleForConst. This instr is somewhat of a
combo instr. It used to be emitted as InheritanceSearch + BNE + ConstMissing instr but this ended up being undesirable for a few or reasons: 1. number of overall instrs are larger for no benefit. IR as it exists could not make use of the finer granularity and based on how many side-effecting things get called between constant lookups it was unlikely we will be able to simplify a scope to only lookup a constant once. Also under the IR layer can change const resolution to use the same invokedynamic bindings for the same "constant" in a scope essentially gambling that all constants with the same name will end up referencing the same constant in a given IR scope (which is probably 99.99999% true -- prove this wrong! :) ). 2. increases the size of the CFG for no benefit. not as big of a deal... 3. interpretation is a little bit faster. we moved this logic into Java so we are no longer emulating if statement and doing less overall work. I tried red black bench and saw a small but measurable increase.
Configuration menu - View commit details
-
Copy full SHA for 8426577 - Browse repository at this point
Copy the full SHA 8426577View commit details
There are no files selected for viewing