Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
remove deprecated build_frame and parse_frame methods from Mojo::Tran…
…saction::WebSocket
  • Loading branch information
kraih committed Apr 10, 2016
1 parent 24ce94c commit 544595a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 16 deletions.
2 changes: 2 additions & 0 deletions Changes
@@ -1,5 +1,7 @@

6.58 2016-04-09
- Removed deprecated build_frame and parse_frame methods from
Mojo::Transaction::WebSocket.
- Added fork policy to Mojolicious::Guides::Contributing.
- Improved Mojo::JSON to generate canonical JSON objects.
- Fixed bug in Mojo::Loader where classes with exceptions could not be loaded
Expand Down
14 changes: 1 addition & 13 deletions lib/Mojo/Transaction/WebSocket.pm
Expand Up @@ -5,19 +5,13 @@ use Compress::Raw::Zlib 'Z_SYNC_FLUSH';
use Config;
use List::Util 'first';
use Mojo::JSON qw(encode_json j);
use Mojo::Util qw(decode deprecated encode trim);
use Mojo::Util qw(decode encode trim);
use Mojo::WebSocket
qw(WS_BINARY WS_CLOSE WS_CONTINUATION WS_PING WS_PONG WS_TEXT);

has [qw(compressed established handshake masked)];
has max_websocket_size => sub { $ENV{MOJO_MAX_WEBSOCKET_SIZE} || 262144 };

# DEPRECATED!
sub build_frame {
deprecated 'Mojo::Transaction::WebSocket::build_frame is DEPRECATED';
Mojo::WebSocket::build_frame(shift->masked, @_);
}

sub build_message {
my ($self, $frame) = @_;

Expand Down Expand Up @@ -73,12 +67,6 @@ sub kept_alive { shift->handshake->kept_alive }
sub local_address { shift->handshake->local_address }
sub local_port { shift->handshake->local_port }

# DEPRECATED!
sub parse_frame {
deprecated 'Mojo::Transaction::WebSocket::parse_frame is DEPRECATED';
Mojo::WebSocket::parse_frame($_[1], $_[0]->max_websocket_size);
}

sub parse_message {
my ($self, $frame) = @_;

Expand Down
4 changes: 1 addition & 3 deletions t/pod_coverage.t
Expand Up @@ -13,9 +13,7 @@ my %RULES = (
'Mojo::Server::Daemon' => {also_private => ['multi_accept']},
'Mojo::Server::Morbo' => {also_private => ['check']},
'Mojo::Template' => {also_private => ['build', 'compile', 'interpret']},
'Mojo::Transaction::WebSocket' =>
{also_private => [qw(build_frame parse_frame)]},
'Mojo::Util' => {also_private => ['xss_escape']}
'Mojo::Util' => {also_private => ['xss_escape']}
);
pod_coverage_ok($_, $RULES{$_} || {}) for all_modules();

Expand Down

0 comments on commit 544595a

Please sign in to comment.