unixODBCDrivers: fix broken module invocation #14598
Conversation
environment.unixODBCDrivers was broken, because the type was `package`,
but the drivers were attrsets that looked like this:
{ ini = "…"; deriv = <derivation>; }
Keep the module type, but move the .inis into `passthru`.
Remove `psqlng`, which has been broken since 2008 and was
never finished.
unixODBCDrivers.mysql is broken.
Tested by inserting all available packages in `unixODBCDrivers` and
rebuilding.
|
By analyzing the blame information on this pull request, we identified @MarcWeber, @vlstill and @bjornfor to be potential reviewers |
|
@Profpatsch: Merge conflicts. (I think @abbradar has pushed some improvements to unixODBCDrivers in the meantime.) |
|
Well, it’s been more than a month. |
|
@Profpatsch I haven't known about your work, sorry. I, too, moved INI attributes to EDIT: I have also removed additional tweaks from INI files. My reasoning has been that tweaks should be specified case-by-case and we should stick to defaults. However, if those tweaks are actually considered de facto defaults we can return them -- I'm not knowledgeable enough about ODBC. |
|
Reminds me, I have a couple of old branches that attempted to fix MySQL. Never got it to work though. (Why do upstreams make it so difficult to build their software?) |
|
I stopped somewhere when after patching CMake to search for MySQL modules properly I got some compilation error. This all is child's play however compared to Telegram Desktop's building system... but this is offtopic, I just haven't healed mental damage fully. |
|
@abbradar: OT: Right, I remember you wrote a bit about that in the PR. Sounded horrible! I hope you eventually heal. |
|
is this still relevant? |
|
Yes, probably. I will probably have the chance to test it in a few weeks. |
|
@Profpatsch Please write an issue for this and close this PR if you cannot implement this. |
That’s some strange wording because there is already an issue (this one) and I am positively able to implement it (as this issue shows). I will close it, though, because it hasn’t been relevant to me in ages. |
|
@Profpatsch A PR is not an issue. A PR is a possible solution to an issue. |
|
@Profpatsch If you don't have the interest to fix this, it still means you cannot implement it (due to lack of interest). Whether or not you could implement this given a billion dollars as motivation for example, is not what was under discussion. |
environment.unixODBCDrivers was broken, because the type was
package,but the drivers were attrsets that looked like this:
Keep the module type, but move the .inis into
passthru.Remove
psqlng, which has been broken since 2008 and wasnever finished.
unixODBCDrivers.mysql is broken.
Tested by inserting all available packages in
unixODBCDriversandrebuilding.