-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinite recursion in ActionDispatch::Request::Session.inspect #3793
Comments
Also present on JRuby 1.7.24
|
interestingly I am not able to reproduce on Ubuntu ... tried Java 7 as well as 8 with 1.7.24 :
|
@kares did you set your |
I don't think the two reify flags are a good idea to have on...they were experimental in 1.7 and reify.variables defaulted to true for the first time in 9.1. It appears that having reify.classes enabled causes this issue. It used to work properly, so we must have broken it somehow...or perhaps it never worked for the particular object structure we're dealign with here. reify.classes has never been made official, but now might be a good time. It would need to be unified with reify.variables, since both flags attempt to change what actual objects get allocated for a Ruby class. We may or may not do this in 1.7, but I think it's a good time to get class reification stable in 9k. Short term workaround: remove reify.classes from your JRUBY_OPTS and it should run fine. |
Reasonable workaround for now and larger work needed to get reify.classes working properly again. |
Closing in favor of a new task issue. The reify.classes feature is still experimental and unsupported with reify.variables, which has been enabled and working well for some time. I have plans to rework reify.variables to actually generate the specialized class shapes, but that will happen after 9.2. At that point I will look into whether we can actually just do the reify.classes logic as part of the generated subclasses. |
I am seeing infinite recursion in the java stack that is just
ActionDispatch::Request::Session#inspect
calling itself forever. The implementation of this callssuper
but the class does not explicitly inherit from any class.This was not reproducible on a Mac OSX machine with JRuby 1.7.22
Example script
Environment
Expected Behavior
JRuby should behave just like Ruby 1.9.3 when running my example script
From Ruby 1.9.3
Actual Behavior
Infinite recursion is seen in the java stack
From JRuby 1.7.22
The text was updated successfully, but these errors were encountered: