Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add an option to colorize to respect the destination alpha
Also, rework the colorizing code to be more efficient.
- Loading branch information
Showing
2 changed files
with
56 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01ae43c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kwolekr can you please tell who gave the second 👍 to this change?
The compiler warnings this commit added are fixed fortunately, but the documentation of the new feature is a bit weird and needs improvement.
Its good to have you back after your pause but the rules didn't change since then, and this feature certainly isn't trivial.
It would be great if you could motivate another dev to +1 this commit (or another dev already +1ed it) in the next three days, and get possibly suggested changes/fixes merged. If no dev +1es it in that time, I'll revert the commit (and the commit that fixes the compilation warnings, because otherwise stuff wont work anymore).
Please respond in this thread (I'm not closely reading every IRC line) or the pull request #3899.